From a67bdd7ccfd8e34f2ece1025a88334a639223784 Mon Sep 17 00:00:00 2001 From: Lucas Legname Date: Wed, 2 Jul 2014 21:06:42 +0200 Subject: [PATCH 1/2] Code cleaning, some dupplicated code have been deleted and the main page is now totally unified. --- index.html | 104 ++++++++++++++------------------------ src/index.html | 85 ++++++++++--------------------- src/main.css | 6 ++- src/ninja.misc.js | 4 -- src/ninja.singlewallet.js | 5 +- 5 files changed, 72 insertions(+), 132 deletions(-) diff --git a/index.html b/index.html index 56705a2..7017579 100644 --- a/index.html +++ b/index.html @@ -9326,6 +9326,10 @@ body { font-family: Arial; background-image: url('images/diamonds.png'); height: .answer { padding: 0 15px 10px 25px; text-align: left; display: none; font-size: 80%; } .faq { border: 0; border-top: 1px solid #BFBFBF; } +#initBanner { position: relative; text-align: left; padding: 15px; background-color: white; border-bottom: 1px solid #bfbfbf; } +#walletCommands { display: none; } +#keyarea { display: none; } + #btcaddress, #btcprivwif, #detailaddress, #detailaddresscomp, #detailprivwif, #detailprivwifcomp { font-family: monospace; font-size: 1.25em; } #seedpoolarea { display: none; } #seedpooldisplay { font-family: monospace; font-size: 1em; width: 640px; padding: 15px 5px; word-wrap: break-word; min-height: 98px; } @@ -9363,7 +9367,7 @@ h1 { margin: 0px; height: 91px; } #keyarea .qrcode_private { float: none; display: block; top: 0; text-align: right; padding: 13px 11px 11px 11px; } #keyarea .private { width: 30%; display: table-cell; } #keyarea .public { width: 30%; display: table-cell; } -#singlearea { font-size: 90%; } +#singlearea { font-size: 90%; display: block; } #singlesecret { position: relative; top: -130px; float: right; right: 200px; color: red; font-weight: bolder; font-size: 200%; } #singleshare { position: relative; top: -110px; float: left; left: 160px; color: green; font-weight: bolder; font-size: 200%; } #singlesafety { text-align: left; border-top: 1px solid #BFBFBF; position: relative; min-height: 500px; } @@ -9686,68 +9690,29 @@ h1 { margin: 0px; height: 91px; }
Wallet Details
- -
- - - Generating new Address...
- MOVE your mouse around to add some extra randomness...
- OR type some random characters into this textbox
-
- -
-
-
-
- -
- Skip » -

You may skip this step if you do not plan to use the random key generator.

-
-
- -
- -
- -
- -
- Supported currencies : -
-
- -
-

Step 0. Follow the security checklist recommendation

-

- First step is to download this website from Github and open the index.html file directly from your computer. It's just too easy to sneak some evil code in the 6000+ lines of javascript to leak your private key, and you don't want to see your fund stolen. Code version control make it much easier to cross-check what actually run. For extra security, unplug your Internet access while generating your wallet. -

-
- -
- Security Checklist : - -
    -
  • - -
  • - -
  • - Are you using a secure operating system guaranteed to be free of spyware and viruses, for example, an Ubuntu LiveCD? -
    • -
-
- -
-
- Paper wallet from walletgenerator.net -
-
-
-
+ +
+ Generating new Address...
+ MOVE your mouse around to add some extra randomness...
+ OR type some random characters into this textbox
+
+ +
+
+
+
+ +
+ Skip » +

You may skip this step if you do not plan to use the random key generator.

+
+
+
+ +
@@ -9778,6 +9743,7 @@ h1 { margin: 0px; height: 91px; }
+

Step 0. Follow the security checklist recommendation

First step is to download this website from Github and open the index.html file directly from your computer. It's just too easy to sneak some evil code in the 6000+ lines of javascript to leak your private key, and you don't want to see your fund stolen. Code version control make it much easier to cross-check what actually run. For extra security, unplug your Internet access while generating your wallet. @@ -9829,6 +9795,11 @@ h1 { margin: 0px; height: 91px; }

+ +
+ Supported currencies : +
+
@@ -10314,11 +10285,11 @@ janin.currencies = [ janin.currency.createCurrency ("Fastcoin", 0x60, 0xe0, "8", "a" , "frxe8F7gQdiAVgy4mRXjpXH5vN1wyta1db"), janin.currency.createCurrency ("Feathercoin",0x0e, 0x8e, "5", "N" , "6dxAP6oacHsove5X2kZPpddcT1Am167YzC"), janin.currency.createCurrency ("Fluttercoin",0x23, 0xa3, "6", "R" , "FJioRLt3gLtqk3tUdMhwjAVo1sdWjRuwqt"), - janin.currency.createCurrency ("Fuelcoin",0x24, 0xa4, "6", "R" , ""), + janin.currency.createCurrency ("Fuelcoin", 0x24, 0xa4, "6", "R" , ""), janin.currency.createCurrency ("GlobalBoost",0x26, 0xa6, "6", "R" , "GeXdH1WhzA7ayYim9sdCCQKcVukUq1W8LJ"), janin.currency.createCurrency ("Goodcoin", 0x26, 0xa6, "6", "R" , "GM3kAbQGaMVAYk8U3CrVGhSwz1hZaF6gVM"), janin.currency.createCurrency ("Gridcoin", 0x25, 0xa5, "6", "R" , "FyYkg3xhJVcVzMMw8JKfQaBxA9DAVhivq4"), - janin.currency.createCurrency ("Guldencoin",0x26, 0xa6, "6", "R" , ""), + janin.currency.createCurrency ("Guldencoin", 0x26, 0xa6, "6", "R" , ""), janin.currency.createCurrency ("Guncoin", 0x27, 0xa7, "6", "R" , "GwVej6c3tF9GqEdSKmwJiUDWtQVK2wY9fP"), janin.currency.createCurrency ("HTMLCoin", 0x1e, 0x9e, "6", "Q" , "DP4AVuekGEatNmpCL99m46k8THwS9yNVqy"), janin.currency.createCurrency ("Litecoin", 0x30, 0xb0, "6", "T" , "LiScnsyPcqsyxn1fx92BcFguryXcw4DgCy"), @@ -10715,7 +10686,6 @@ ninja.publicKey = { if (ninja.seeder.seedCount == ninja.seeder.seedLimit) { ninja.seeder.seedCount++; ninja.wallets.singlewallet.open(); - document.getElementById("generate").style.display = "none"; document.getElementById("menu").style.visibility = "visible"; ninja.seeder.removePoints(); } @@ -10737,7 +10707,6 @@ ninja.publicKey = { if (ninja.seeder.seedCount == ninja.seeder.seedLimit) { ninja.seeder.seedCount++; ninja.wallets.singlewallet.open(); - document.getElementById("generate").style.display = "none"; document.getElementById("menu").style.visibility = "visible"; ninja.seeder.removePoints(); } @@ -10913,7 +10882,6 @@ ninja.envSecurityCheck = function() { default: } document.getElementById('envSecurityCheck').innerHTML = innerHTML; - document.getElementById('seedEnvSecurityCheck').innerHTML = innerHTML; }; ninja.browserSecurityCheck = function() { @@ -10924,7 +10892,6 @@ ninja.browserSecurityCheck = function() { innerHTML = 'Your browser does NOT support window.crypto.getRandomValues(), which is important for generating the most secure random numbers possible. Please use a more modern browser.'; } document.getElementById('browserSecurityCheck').innerHTML = innerHTML; - document.getElementById('seedBrowserSecurityCheck').innerHTML = innerHTML; } ninja.getQueryString = function () { @@ -11871,8 +11838,11 @@ ninja.wallets.singlewallet = { if (document.getElementById("btcaddress").innerHTML == "") { ninja.wallets.singlewallet.generateNewAddressAndKey(); } - document.getElementById("singlearea").style.display = "block"; + document.getElementById("walletCommands").style.display = "block"; + document.getElementById("keyarea").style.display = "block"; document.getElementById("currencyddl").style.display = "block"; + + document.getElementById("initBanner").style.display = "none"; }, close: function () { diff --git a/src/index.html b/src/index.html index 973544f..2a16da8 100644 --- a/src/index.html +++ b/src/index.html @@ -155,68 +155,29 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
Wallet Details
- -
- - - Generating new Address...
- MOVE your mouse around to add some extra randomness...
- OR type some random characters into this textbox
-
- -
-
-
-
- -
- Skip » -

You may skip this step if you do not plan to use the random key generator.

-
-
- -
- -
- -
- -
- Supported currencies : -
-
- -
-

Step 0. Follow the security checklist recommendation

-

- First step is to download this website from Github and open the index.html file directly from your computer. It's just too easy to sneak some evil code in the 6000+ lines of javascript to leak your private key, and you don't want to see your fund stolen. Code version control make it much easier to cross-check what actually run. For extra security, unplug your Internet access while generating your wallet. -

-
- -
- Security Checklist : - -
    -
  • - -
  • - -
  • - Are you using a secure operating system guaranteed to be free of spyware and viruses, for example, an Ubuntu LiveCD? -
    • -
-
- -
-
- Paper wallet from walletgenerator.net -
-
-
-
+ +
+ Generating new Address...
+ MOVE your mouse around to add some extra randomness...
+ OR type some random characters into this textbox
+
+ +
+
+
+
+ +
+ Skip » +

You may skip this step if you do not plan to use the random key generator.

+
+
+
+ +
@@ -247,6 +208,7 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+

Step 0. Follow the security checklist recommendation

First step is to download this website from Github and open the index.html file directly from your computer. It's just too easy to sneak some evil code in the 6000+ lines of javascript to leak your private key, and you don't want to see your fund stolen. Code version control make it much easier to cross-check what actually run. For extra security, unplug your Internet access while generating your wallet. @@ -298,6 +260,11 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

+ +
+ Supported currencies : +
+
diff --git a/src/main.css b/src/main.css index 6520778..6b4b336 100644 --- a/src/main.css +++ b/src/main.css @@ -22,6 +22,10 @@ body { font-family: Arial; background-image: url('images/diamonds.png'); height: .answer { padding: 0 15px 10px 25px; text-align: left; display: none; font-size: 80%; } .faq { border: 0; border-top: 1px solid #BFBFBF; } +#initBanner { position: relative; text-align: left; padding: 15px; background-color: white; border-bottom: 1px solid #bfbfbf; } +#walletCommands { display: none; } +#keyarea { display: none; } + #btcaddress, #btcprivwif, #detailaddress, #detailaddresscomp, #detailprivwif, #detailprivwifcomp { font-family: monospace; font-size: 1.25em; } #seedpoolarea { display: none; } #seedpooldisplay { font-family: monospace; font-size: 1em; width: 640px; padding: 15px 5px; word-wrap: break-word; min-height: 98px; } @@ -59,7 +63,7 @@ h1 { margin: 0px; height: 91px; } #keyarea .qrcode_private { float: none; display: block; top: 0; text-align: right; padding: 13px 11px 11px 11px; } #keyarea .private { width: 30%; display: table-cell; } #keyarea .public { width: 30%; display: table-cell; } -#singlearea { font-size: 90%; } +#singlearea { font-size: 90%; display: block; } #singlesecret { position: relative; top: -130px; float: right; right: 200px; color: red; font-weight: bolder; font-size: 200%; } #singleshare { position: relative; top: -110px; float: left; left: 160px; color: green; font-weight: bolder; font-size: 200%; } #singlesafety { text-align: left; border-top: 1px solid #BFBFBF; position: relative; min-height: 500px; } diff --git a/src/ninja.misc.js b/src/ninja.misc.js index 040757b..ecb6725 100644 --- a/src/ninja.misc.js +++ b/src/ninja.misc.js @@ -21,7 +21,6 @@ if (ninja.seeder.seedCount == ninja.seeder.seedLimit) { ninja.seeder.seedCount++; ninja.wallets.singlewallet.open(); - document.getElementById("generate").style.display = "none"; document.getElementById("menu").style.visibility = "visible"; ninja.seeder.removePoints(); } @@ -43,7 +42,6 @@ if (ninja.seeder.seedCount == ninja.seeder.seedLimit) { ninja.seeder.seedCount++; ninja.wallets.singlewallet.open(); - document.getElementById("generate").style.display = "none"; document.getElementById("menu").style.visibility = "visible"; ninja.seeder.removePoints(); } @@ -219,7 +217,6 @@ ninja.envSecurityCheck = function() { default: } document.getElementById('envSecurityCheck').innerHTML = innerHTML; - document.getElementById('seedEnvSecurityCheck').innerHTML = innerHTML; }; ninja.browserSecurityCheck = function() { @@ -230,7 +227,6 @@ ninja.browserSecurityCheck = function() { innerHTML = 'Your browser does NOT support window.crypto.getRandomValues(), which is important for generating the most secure random numbers possible. Please use a more modern browser.'; } document.getElementById('browserSecurityCheck').innerHTML = innerHTML; - document.getElementById('seedBrowserSecurityCheck').innerHTML = innerHTML; } ninja.getQueryString = function () { diff --git a/src/ninja.singlewallet.js b/src/ninja.singlewallet.js index 568c4ce..737b849 100644 --- a/src/ninja.singlewallet.js +++ b/src/ninja.singlewallet.js @@ -3,8 +3,11 @@ ninja.wallets.singlewallet = { if (document.getElementById("btcaddress").innerHTML == "") { ninja.wallets.singlewallet.generateNewAddressAndKey(); } - document.getElementById("singlearea").style.display = "block"; + document.getElementById("walletCommands").style.display = "block"; + document.getElementById("keyarea").style.display = "block"; document.getElementById("currencyddl").style.display = "block"; + + document.getElementById("initBanner").style.display = "none"; }, close: function () { From 8517d9aa41cbca7019ea74b2cd0d12c8be9d2d3d Mon Sep 17 00:00:00 2001 From: Lucas Legname Date: Wed, 2 Jul 2014 22:33:44 +0200 Subject: [PATCH 2/2] FAQ added on the main page. --- index.html | 76 +++++++++++++++++++++++++++++++++++++++++++---- src/index.html | 61 ++++++++++++++++++++++++++++++++++--- src/main.css | 10 +++++-- src/ninja.misc.js | 5 ++++ 4 files changed, 140 insertions(+), 12 deletions(-) diff --git a/index.html b/index.html index 7017579..a24398e 100644 --- a/index.html +++ b/index.html @@ -9330,6 +9330,12 @@ body { font-family: Arial; background-image: url('images/diamonds.png'); height: #walletCommands { display: none; } #keyarea { display: none; } +#faqZone { text-align: left; padding: 10px 30px 30px 30px; } +.faqQuestion { margin-left: 15px; } +.faqAnswer { margin-left: 30px; } +.faqListBullet { padding: 0 5px 0px 15px; } +.faqLink { cursor: pointer; } + #btcaddress, #btcprivwif, #detailaddress, #detailaddresscomp, #detailprivwif, #detailprivwifcomp { font-family: monospace; font-size: 1.25em; } #seedpoolarea { display: none; } #seedpooldisplay { font-family: monospace; font-size: 1em; width: 640px; padding: 15px 5px; word-wrap: break-word; min-height: 98px; } @@ -9359,7 +9365,7 @@ body { font-family: Arial; background-image: url('images/diamonds.png'); height: h1 { margin: 0px; height: 91px; } -#keyarea { height: 250px; } +#keyarea { height: 250px; border-bottom: 1px solid #bfbfbf; } #keyarea .pubaddress { float: none; display: block; padding: 0; height: auto; } #keyarea .label { text-decoration: none; } #keyarea .privwif { float: none; text-align: right; position: relative; padding: 0; } @@ -9370,7 +9376,7 @@ h1 { margin: 0px; height: 91px; } #singlearea { font-size: 90%; display: block; } #singlesecret { position: relative; top: -130px; float: right; right: 200px; color: red; font-weight: bolder; font-size: 200%; } #singleshare { position: relative; top: -110px; float: left; left: 160px; color: green; font-weight: bolder; font-size: 200%; } -#singlesafety { text-align: left; border-top: 1px solid #BFBFBF; position: relative; min-height: 500px; } +#singlesafety { text-align: left; border-bottom: 1px solid #bfbfbf; position: relative; min-height: 500px; } #singlesafety p { font-size: 13px; } @@ -9775,9 +9781,7 @@ h1 { margin: 0px; height: 91px; } Please test spending a small amount before receiving any large payments.

-

- For an extended tutorial on paper wallets, click here -

+
Overview image of 4 paper wallet @@ -9801,7 +9805,62 @@ h1 { margin: 0px; height: 91px; }
- +
+ +
+

Frequently asked questions :

+ +

• Is it safe ?

+

+ We try to make it that way ! The core the tool, that generate the keys is 99% the same as the well reviewed bitaddress.org. We only changed it to be able to generate address for different crypto-currencies. +We think that having a unique generator for multiple currency lead to a much better reviewed tool for all than having a myriad of half backed generator. +Changes made to this generator are available on Github in small and divided commits and thus are easy to review and reuse. +Walletgenerator.net use the same security measure as its original. All-in-one html document, no ajax, no analytics, no external calls, no CDN that can inject anything they want. And trust us, we have seen some nasty things when reviewing some wallet generator. +

+ +

• Why use a paper wallet ?

+

+ Advantages of a paper wallet are multiple:

+ ⇒ They are not subject to malware and keylogger
+ ⇒ You don’t rely on a third party’s honesty or capacity to protect your coins
+ ⇒ You won't lose your coin when your device break +

+ +

• How to use a paper wallet ?

+

+ Once you have generated and printed a wallet, you can send coins to the public address, like for any wallet. Store your paper wallet securely. It contains everything that is needed to spend your funds. Consider using BIP38 to secure your paper wallet with a password. +

+ +

• How to spend the coin stored in a paper wallet ?

+

+ You will need to import your private key in a real client, that you can download from the currency website. The exact method to do that will depend on the client. If there is no integrated method, you can usually fall back to the debug console and use the command “importprivkey yourprivatekey“. +

+ +

• How walletgenerator.net is different than another wallet generator ?

+

+ It’s not that different. You will find another design for the paper wallet and some improvement here and there. The big difference is that this is a unique project for a lot of currencies, so more people can review it and check its safety. +

+ +

• Where is the https:// ?

+

+ There is none. The web hosting solution we currently use doesn't provide SSL support, so we would need to upgrade that. It should happen in the future, but remember that there is almost no point in doing that. You are not supposed to generate anything from the live website, and even if you do, as everything is client-side javascript, HTTPS won’t help you at all. +

+ +

• Can you add support for cryptocurrency XYZ ?

+

+ Absolutely ! To help us do that, you can provide us a high resolution logo, some sample of public address, the link to download a client, a very short amount of the currency to make some test. But keep in mind that there is some currency that we cannot support. If the developers made some change in the address format, we won’t hack the crypto core of the project and taking the risk to tamper the security of the others currencies. Please contact us using Twitter or Github. +

+ +

• Why should I make a donation ?

+

+ Donations money are used to pay our hosting service provider, but it’ll also be used to make walletgenerator.net more secure as we plan to organize a CrowdCurity campain as soon as we get enough money to pay for it. +

+ +

• I found a bug, what shall I do ?

+

+ You can report bugs using GitHub. You can also contact us using our twitter account (@WalletGenerator). Just try to explain clearly what is wrong and we will try to fix the bug as soon as possible. +

+
@@ -10935,6 +10994,11 @@ ninja.foreachSerialized = function (collection, whatToDo, onComplete) { whatToDo(keys[i], callback); }, onComplete); }; + +ninja.toggleFaqQuestion = function (elementId) { + var answerDiv = document.getElementById(elementId); + answerDiv.style.display = answerDiv.style.display == "none" ? "block" : "none"; +};