zervo/seb-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

handle connection with deleted Connection Configs

Browse source
This commit is contained in:
anhefti 2022-05-12 08:29:40 +02:00
parent 63957d9156
commit 38b28838fe
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/SEBClientConnectionServiceImpl.java
View file

@ -25,6 +25,7 @@ import org.slf4j.LoggerFactory;
import org.springframework.cache.Cache;
import org.springframework.cache.CacheManager;
import org.springframework.context.annotation.Lazy;
import org.springframework.security.access.AccessDeniedException;
import org.springframework.stereotype.Service;
import ch.ethz.seb.sebserver.gbl.Constants;
@ -120,7 +121,13 @@ public class SEBClientConnectionServiceImpl implements SEBClientConnectionServic
final SEBClientConfig clientConfig = this.sebClientConfigDAO
.byClientName(principal.getName())
.getOrThrow();
.getOr(null);
if (clientConfig == null) {
log.error("Illegal client connection request: requested connection config name: {}",
principal.getName());
throw new AccessDeniedException("Unknown or illegal client access");
}
if (!clientConfig.institutionId.equals(institutionId)) {
log.error("Institutional integrity violation: requested institution: {} authenticated institution: {}",