zervo/seb-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

better logging for moodle access

Browse source
This commit is contained in:
anhefti 2021-03-17 09:08:17 +01:00
parent 1dadca2eae
commit 40b0426129
1 changed files with 38 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/lms/impl/moodle/MoodleRestTemplateFactory.java
View file

@ -336,6 +336,7 @@ class MoodleRestTemplateFactory {
private void requestAccessToken() { private void requestAccessToken() {
try {
final ResponseEntity<String> response = super.exchange( final ResponseEntity<String> response = super.exchange(
this.serverURL + this.tokenPath, this.serverURL + this.tokenPath,
HttpMethod.GET, HttpMethod.GET,
@ -344,6 +345,10 @@ class MoodleRestTemplateFactory {
this.tokenReqURIVars); this.tokenReqURIVars);
if (response.getStatusCode() != HttpStatus.OK) { if (response.getStatusCode() != HttpStatus.OK) {
log.error("Failed to gain access token for LMS (Moodle): lmsSetup: {} response: {} : {}",
MoodleRestTemplateFactory.this.lmsSetup,
response.getStatusCode(),
response.getBody());
throw new RuntimeException("Failed to gain access token for LMS (Moodle): lmsSetup: " + throw new RuntimeException("Failed to gain access token for LMS (Moodle): lmsSetup: " +
MoodleRestTemplateFactory.this.lmsSetup + " response: " + response.getBody()); MoodleRestTemplateFactory.this.lmsSetup + " response: " + response.getBody());
} }
@ -353,11 +358,27 @@ class MoodleRestTemplateFactory {
response.getBody(), response.getBody(),
MoodleToken.class); MoodleToken.class);
if (moodleToken == null || moodleToken.token == null) {
throw new RuntimeException("Access Token request with 200 but no or invalid token body");
}
this.accessToken = moodleToken.token; this.accessToken = moodleToken.token;
} catch (final Exception e) { } catch (final Exception e) {
log.error("Failed to gain access token for LMS (Moodle): lmsSetup: {} response: {} : {}",
MoodleRestTemplateFactory.this.lmsSetup,
response.getStatusCode(),
response.getBody());
throw new RuntimeException("Failed to gain access token for LMS (Moodle): lmsSetup: " + throw new RuntimeException("Failed to gain access token for LMS (Moodle): lmsSetup: " +
MoodleRestTemplateFactory.this.lmsSetup + " response: " + response.getBody(), e); MoodleRestTemplateFactory.this.lmsSetup + " response: " + response.getBody(), e);
} }
} catch (final Exception e) {
log.error("Failed to gain access token for LMS (Moodle): lmsSetup: {} :",
MoodleRestTemplateFactory.this.lmsSetup,
e);
throw new RuntimeException("Failed to gain access token for LMS (Moodle): lmsSetup: " +
MoodleRestTemplateFactory.this.lmsSetup + " cause: " + e.getMessage());
}
} }
} }