diff --git a/src/main/java/ch/ethz/seb/sebserver/gui/service/page/impl/PageServiceImpl.java b/src/main/java/ch/ethz/seb/sebserver/gui/service/page/impl/PageServiceImpl.java index 73ebd521..90c6a5fd 100644 --- a/src/main/java/ch/ethz/seb/sebserver/gui/service/page/impl/PageServiceImpl.java +++ b/src/main/java/ch/ethz/seb/sebserver/gui/service/page/impl/PageServiceImpl.java @@ -20,7 +20,6 @@ import java.util.function.Supplier; import javax.servlet.http.HttpSession; -import ch.ethz.seb.sebserver.gbl.util.Cryptor; import org.eclipse.rap.rwt.RWT; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -36,6 +35,7 @@ import ch.ethz.seb.sebserver.gbl.model.Entity; import ch.ethz.seb.sebserver.gbl.model.EntityKey; import ch.ethz.seb.sebserver.gbl.model.Page; import ch.ethz.seb.sebserver.gbl.profile.GuiProfile; +import ch.ethz.seb.sebserver.gbl.util.Cryptor; import ch.ethz.seb.sebserver.gbl.util.Result; import ch.ethz.seb.sebserver.gui.form.FormBuilder; import ch.ethz.seb.sebserver.gui.service.ResourceService; @@ -227,7 +227,7 @@ public class PageServiceImpl implements PageService { final int dependencies = (int) entities.stream() .flatMap(entity -> { final RestCall>.RestCallBuilder builder = - restService.getBuilder( + restService.> getBuilder( entity.entityType(), CallType.GET_DEPENDENCIES); @@ -254,7 +254,7 @@ public class PageServiceImpl implements PageService { public Function activationToggleActionFunction( final EntityTable table, final LocTextKey noSelectionText, - Function testBeforeActivation) { + final Function testBeforeActivation) { return action -> { final Set selectedROWData = table.getSelectedROWData(); @@ -269,7 +269,7 @@ public class PageServiceImpl implements PageService { for (final T entity : selectedROWData) { if (!entity.isActive()) { - RestCall.RestCallBuilder restCallBuilder = restService.getBuilder( + final RestCall.RestCallBuilder restCallBuilder = restService. getBuilder( entityType, CallType.ACTIVATION_ACTIVATE) .withURIVariable(API.PARAM_MODEL_ID, entity.getModelId()); @@ -280,7 +280,7 @@ public class PageServiceImpl implements PageService { restCallBuilder .call() .onError(errors::add); - } catch (Exception e) { + } catch (final Exception e) { errors.add(e); } } else { @@ -289,7 +289,7 @@ public class PageServiceImpl implements PageService { .onError(errors::add); } } else { - restService.getBuilder(entityType, CallType.ACTIVATION_DEACTIVATE) + restService. getBuilder(entityType, CallType.ACTIVATION_DEACTIVATE) .withURIVariable(API.PARAM_MODEL_ID, entity.getModelId()) .call() .onError(errors::add); @@ -347,7 +347,7 @@ public class PageServiceImpl implements PageService { @Override public FormBuilder formBuilder(final PageContext pageContext, final int rows) { - return new FormBuilder(this, pageContext, cryptor, rows); + return new FormBuilder(this, pageContext, this.cryptor, rows); } @Override diff --git a/src/main/java/ch/ethz/seb/sebserver/gui/widget/ImageUploadSelection.java b/src/main/java/ch/ethz/seb/sebserver/gui/widget/ImageUploadSelection.java index eec2cad2..6b7cf37e 100644 --- a/src/main/java/ch/ethz/seb/sebserver/gui/widget/ImageUploadSelection.java +++ b/src/main/java/ch/ethz/seb/sebserver/gui/widget/ImageUploadSelection.java @@ -48,7 +48,10 @@ public final class ImageUploadSelection extends Composite { private static final long serialVersionUID = 368264811155804533L; private static final Logger log = LoggerFactory.getLogger(ImageUploadSelection.class); - public static final Set SUPPORTED_IMAGE_FILES = Set.of(".png", ".jpg", ".jpeg"); + public static final Set SUPPORTED_IMAGE_FILES = Collections.unmodifiableSet(new HashSet<>(Arrays.asList( + ".png", + ".jpg", + ".jpeg"))); private final ServerPushService serverPushService;