From 6b1d5f91799039c2f0d8b1f819f627e4ce8b3e34 Mon Sep 17 00:00:00 2001 From: anhefti Date: Thu, 12 Nov 2020 14:27:59 +0100 Subject: [PATCH] error handling on proc update --- .../impl/ExamProctoringRoomServiceImpl.java | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/ExamProctoringRoomServiceImpl.java b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/ExamProctoringRoomServiceImpl.java index f9b27219..cc39e92f 100644 --- a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/ExamProctoringRoomServiceImpl.java +++ b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/ExamProctoringRoomServiceImpl.java @@ -17,7 +17,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.context.annotation.Lazy; import org.springframework.stereotype.Service; -import org.springframework.transaction.annotation.Transactional; import ch.ethz.seb.sebserver.gbl.model.exam.ProctoringSettings; import ch.ethz.seb.sebserver.gbl.model.exam.ProctoringSettings.ProctoringServerType; @@ -80,17 +79,20 @@ public class ExamProctoringRoomServiceImpl implements ExamProctoringRoomService } @Override - @Transactional public void updateProctoringCollectingRooms() { - this.clientConnectionDAO.getAllConnectionIdsForRoomUpdateActive() - .getOrThrow() - .stream() - .forEach(this::assignToRoom); + try { + this.clientConnectionDAO.getAllConnectionIdsForRoomUpdateActive() + .getOrThrow() + .stream() + .forEach(this::assignToRoom); - this.clientConnectionDAO.getAllConnectionIdsForRoomUpdateInactive() - .getOrThrow() - .stream() - .forEach(this::removeFromRoom); + this.clientConnectionDAO.getAllConnectionIdsForRoomUpdateInactive() + .getOrThrow() + .stream() + .forEach(this::removeFromRoom); + } catch (final Exception e) { + log.error("Unexpected error while trying to update proctoring collecting rooms: ", e); + } } @Override