From 9e5a0085b32d9dd77867d93029019cc6a5c77abd Mon Sep 17 00:00:00 2001 From: anhefti Date: Wed, 21 Aug 2024 10:52:09 +0200 Subject: [PATCH] SEBSERV-580 fixed by skip active testing for Exam without LMS --- .../servicelayer/session/ScreenProctoringService.java | 2 +- .../session/impl/proctoring/ScreenProctoringServiceImpl.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/ScreenProctoringService.java b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/ScreenProctoringService.java index b4612e5b..3a738eae 100644 --- a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/ScreenProctoringService.java +++ b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/ScreenProctoringService.java @@ -100,7 +100,7 @@ public interface ScreenProctoringService extends SessionUpdateTask { void updateClientConnections(); /** This goes through all running exams with screen proctoring enabled and updates the group attributes - * (mainly the number of active clients in the group) by call ing SPS API and store newest data. */ + * (mainly the number of active clients in the group) by calling SPS API and store newest data. */ void updateActiveGroups(); @Async(AsyncServiceSpringConfig.EXECUTOR_BEAN_NAME) diff --git a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringServiceImpl.java b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringServiceImpl.java index f7d3d549..3c170d9c 100644 --- a/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringServiceImpl.java +++ b/src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringServiceImpl.java @@ -577,6 +577,7 @@ public class ScreenProctoringServiceImpl implements ScreenProctoringService { log.debug("Register JOIN instruction for client "); } + final boolean checkActive = exam.lmsSetupId != null; final SPSData spsData = this.screenProctoringAPIBinding.getSPSData(exam.id); final String url = screenProctoringServiceBundle.bundled ? screenProctoringServiceBundle.serviceURL @@ -597,7 +598,7 @@ public class ScreenProctoringServiceImpl implements ScreenProctoringService { InstructionType.SEB_PROCTORING, attributes, ccRecord.getConnectionToken(), - true, + checkActive, true) .onError(error -> log.error( "Failed to register screen proctoring join instruction for SEB connection: {}",