zervo/seb-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SEBSERV-450 better error handling

Browse source
This commit is contained in:
anhefti 2023-06-15 15:00:57 +02:00
parent 6281634a46
commit ae1561a51a
5 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/ch/ethz/seb/sebserver/gbl/util/Result.java
View file

@ -141,7 +141,7 @@ public final class Result<T> {
if (this.error instanceof RuntimeException) { if (this.error instanceof RuntimeException) {
throw (RuntimeException) this.error; throw (RuntimeException) this.error;
} else { } else {
throw new RuntimeException("RuntimeExceptionWrapper cause: ", this.error); throw new RuntimeException("RuntimeExceptionWrapper cause: " + this.error.getMessage(), this.error);
} }
} }

3
src/main/java/ch/ethz/seb/sebserver/gui/service/page/impl/PageAction.java
View file

@ -185,6 +185,9 @@ public final class PageAction {
} catch (final PageMessageException pme) { } catch (final PageMessageException pme) {
PageAction.this.pageContext.publishPageMessage(pme); PageAction.this.pageContext.publishPageMessage(pme);
return; return;
} catch (final Exception e) {
this.pageContext.notifyUnexpectedError(e);
return;
} }
} else { } else {
callback.accept(exec()); callback.accept(exec());

6
src/main/java/ch/ethz/seb/sebserver/gui/service/remote/webservice/api/RestCall.java
View file

@ -180,7 +180,7 @@ public abstract class RestCall<T> {
e, e,
"NO RESPONSE AVAILABLE", "NO RESPONSE AVAILABLE",
String.valueOf(builder))); String.valueOf(builder)));
return Result.ofError(e); return Result.ofError(restCallError);
} }
} }
@ -216,6 +216,10 @@ public abstract class RestCall<T> {
} else { } else {
restCallError.errors.add(APIMessage.ErrorMessage.GENERIC.of(responseEntity.getBody())); restCallError.errors.add(APIMessage.ErrorMessage.GENERIC.of(responseEntity.getBody()));
} }
} catch (final Exception e) {
final String body = responseEntity.getBody();
log.error("Failed to parse rest response error message: {}", body);
throw e;
} }
log.debug( log.debug(

3
src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/lms/impl/mockup/MockCourseAccessAPI.java
View file

@ -63,7 +63,8 @@ public class MockCourseAccessAPI implements CourseAccessAPI {
"quiz1", institutionId, lmsSetupId, lmsType, "Demo Quiz 1 (MOCKUP)", "<p>Demo Quiz Mockup</p>", "quiz1", institutionId, lmsSetupId, lmsType, "Demo Quiz 1 (MOCKUP)", "<p>Demo Quiz Mockup</p>",
"2020-01-01T09:00:00Z", null, "http://lms.mockup.com/api/")); "2020-01-01T09:00:00Z", null, "http://lms.mockup.com/api/"));
this.mockups.add(new QuizData( this.mockups.add(new QuizData(
"quiz2", institutionId, lmsSetupId, lmsType, "Demo Quiz 2 (MOCKUP)", "<p>Demo Quiz Mockup</p>", "quiz2", institutionId, lmsSetupId, lmsType, "Demo Quiz 2 (MOCKUP) &sd;+1 äöüèÜÄÖ ?<",
"<p>Demo Quiz Mockup &sd;+1 äöüèÜÄÖ ?<</p>",
"2020-01-01T09:00:00Z", "2025-01-01T09:00:00Z", "http://lms.mockup.com/api/")); "2020-01-01T09:00:00Z", "2025-01-01T09:00:00Z", "http://lms.mockup.com/api/"));
this.mockups.add(new QuizData( this.mockups.add(new QuizData(
"quiz3", institutionId, lmsSetupId, lmsType, "Demo Quiz 3 (MOCKUP)", "<p>Demo Quiz Mockup</p>", "quiz3", institutionId, lmsSetupId, lmsType, "Demo Quiz 3 (MOCKUP)", "<p>Demo Quiz Mockup</p>",

4
src/test/java/ch/ethz/seb/sebserver/gui/integration/UseCasesIntegrationTest.java
View file

@ -1578,7 +1578,7 @@ public class UseCasesIntegrationTest extends GuiIntegrationTest {
fail("Exception expected here"); fail("Exception expected here");
} catch (final Exception e) { } catch (final Exception e) {
assertEquals("argument \"content\" is null", e.getMessage()); assertEquals("Unexpected error while rest call", e.getMessage());
} }
// test follow-up integrity violation // test follow-up integrity violation
@ -1596,7 +1596,7 @@ public class UseCasesIntegrationTest extends GuiIntegrationTest {
fail("Exception expected here"); fail("Exception expected here");
} catch (final Exception e) { } catch (final Exception e) {
assertEquals("argument \"content\" is null", e.getMessage()); assertEquals("Unexpected error while rest call", e.getMessage());
} }
final ConfigurationTableValues newTableValue = new ConfigurationTableValues( final ConfigurationTableValues newTableValue = new ConfigurationTableValues(