From bb0df16a56fd2f8b7fb849f84fee8c436dc123f2 Mon Sep 17 00:00:00 2001
From: anhefti <andreas.hefti@let.ethz.ch>
Date: Tue, 20 Aug 2024 11:22:55 +0200
Subject: [PATCH] SEBSERV-574 on access denied check if admin and show hinted
 message

---
 .../proctoring/MonitoringProctoringService.java    | 14 +++++++++++++-
 src/main/resources/messages.properties             |  3 +++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/main/java/ch/ethz/seb/sebserver/gui/service/session/proctoring/MonitoringProctoringService.java b/src/main/java/ch/ethz/seb/sebserver/gui/service/session/proctoring/MonitoringProctoringService.java
index 7e428a2b..199dd158 100644
--- a/src/main/java/ch/ethz/seb/sebserver/gui/service/session/proctoring/MonitoringProctoringService.java
+++ b/src/main/java/ch/ethz/seb/sebserver/gui/service/session/proctoring/MonitoringProctoringService.java
@@ -12,6 +12,7 @@ import java.util.Arrays;
 import java.util.Collection;
 import java.util.Map;
 
+import ch.ethz.seb.sebserver.gbl.model.user.UserRole;
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.BooleanUtils;
 import org.apache.commons.lang3.StringUtils;
@@ -348,6 +349,17 @@ public class MonitoringProctoringService {
                     httpEntity,
                     String.class);
 
+            if (tokenRequest.getStatusCode() == HttpStatus.UNAUTHORIZED &&
+                    currentUser.get().hasAnyRole(UserRole.EXAM_SUPPORTER, UserRole.INSTITUTIONAL_ADMIN)) {
+                log.warn("No Access to Screen Proctoring for user: {}", currentUser.get().username);
+                _action
+                        .pageContext()
+                        .notifyError(
+                                new LocTextKey("sebserver.monitoring.sps.noaccess"),
+                                new RuntimeException("Please make sure you are assigned as supporter for this Exam"));
+                return _action;
+            }
+
             // Open SPS Gui redirect URL with login token (jwt token) in new browser tab
             final String redirectLocation = redirect.getBody() + "/jwt?token=" + tokenRequest.getBody();
        //     final String script = "var win = window.open('', 'seb_screen_proctoring'); win.location.href = '"+ redirectLocation + "';";
@@ -359,7 +371,7 @@ public class MonitoringProctoringService {
         } catch (final Exception e) {
             log.error("Failed to open screen proctoring service group gallery view: ", e);
             _action.pageContext()
-                    .notifyError(new LocTextKey("Failed to open screen proctoring service group gallery view"), e);
+                    .notifyError(new LocTextKey("sebserver.monitoring.sps.opengallery.fail"), e);
         }
         return _action;
     }
diff --git a/src/main/resources/messages.properties b/src/main/resources/messages.properties
index 963d9937..dffe57c9 100644
--- a/src/main/resources/messages.properties
+++ b/src/main/resources/messages.properties
@@ -2423,6 +2423,9 @@ sebserver.monitoring.signaturegrant.signature=App Signature Key Hash
 sebserver.monitoring.signaturegrant.tag=Tag
 sebserver.monitoring.signaturegrant.message.granted=This App Signature Key is already granted for this exam
 
+sebserver.monitoring.sps.opengallery.fail=Failed to open screen proctoring service group gallery view
+sebserver.monitoring.sps.noaccess=No Access to Screen Proctoring
+
 ################################
 # Finished Exams
 ################################