SEBWIN-557: Fixed usage of unencrypted HTTP links.

This commit is contained in:
Damian Büchel 2022-03-01 15:43:33 +01:00
parent eb0dbe0ab4
commit 01af8beedb
3 changed files with 48 additions and 49 deletions

View file

@ -22,7 +22,7 @@ namespace SafeExamBrowser.Configuration.DataFormats
{
public class XmlSerializer : IDataSerializer
{
private ILogger logger;
private readonly ILogger logger;
public XmlSerializer(ILogger logger)
{
@ -45,7 +45,7 @@ namespace SafeExamBrowser.Configuration.DataFormats
using (var writer = XmlWriter.Create(stream, settings))
{
writer.WriteStartDocument();
writer.WriteDocType("plist", "-//Apple Computer//DTD PLIST 1.0//EN", "http://www.apple.com/DTDs/PropertyList-1.0.dtd", null);
writer.WriteDocType("plist", "-//Apple Computer//DTD PLIST 1.0//EN", "https://www.apple.com/DTDs/PropertyList-1.0.dtd", null);
writer.WriteStartElement(XmlElement.Root);
writer.WriteAttributeString("version", "1.0");

View file

@ -89,7 +89,7 @@ namespace SebWindowsConfig.Utilities
var client = new System.Net.WebClient();
client.DownloadFile(
string.Format(@"http://www.google.com/s2/favicons?domain_url={0}", uri.Host),
string.Format(@"https://www.google.com/s2/favicons?domain_url={0}", uri.Host),
TempIconFilename);
return CompressAndEncodeFile(TempIconFilename);
}

View file

@ -35,7 +35,7 @@ namespace SebWindowsConfig.Utilities
{
public static class Plist
{
private static List<int> offsetTable = new List<int>();
private static readonly List<int> offsetTable = new List<int>();
private static List<byte> objectTable = new List<byte>();
private static int refCount;
private static int objRefSize;
@ -130,8 +130,7 @@ namespace SebWindowsConfig.Utilities
using (XmlWriter xmlWriter = XmlWriter.Create(ms, xmlWriterSettings))
{
xmlWriter.WriteStartDocument();
//xmlWriter.WriteComment("DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" " + "\"http://www.apple.com/DTDs/PropertyList-1.0.dtd\"");
xmlWriter.WriteDocType("plist", "-//Apple Computer//DTD PLIST 1.0//EN", "http://www.apple.com/DTDs/PropertyList-1.0.dtd", null);
xmlWriter.WriteDocType("plist", "-//Apple Computer//DTD PLIST 1.0//EN", "https://www.apple.com/DTDs/PropertyList-1.0.dtd", null);
xmlWriter.WriteStartElement("plist");
xmlWriter.WriteAttributeString("version", "1.0");
compose(value, xmlWriter);