zervo/seb-win-refactoring
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: ported first part of IsVirtualRegistry to use IRegistry

Browse source
This commit is contained in:
Notselwyn 2023-07-17 17:06:46 +02:00
parent e99bdabc51
commit 3b8f552138
1 changed files with 19 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
SafeExamBrowser.SystemComponents/VirtualMachineDetector.cs
View file

@ -111,14 +111,16 @@ namespace SafeExamBrowser.SystemComponents
* *
*/ */
IEnumerable<string> hardwareConfigSubkeys; IEnumerable<string> hardwareConfigSubkeys;
if (!registry.TryGetSubKeys("HKLM\\SYSTEM\\HardwareConfig", out hardwareConfigSubkeys)) const string hwConfigParentKey = "HKEY_LOCAL_MACHINE\\SYSTEM\\HardwareConfig";
if (!registry.TryGetSubKeys(hwConfigParentKey, out hardwareConfigSubkeys))
return false; return false;
foreach (string configId in hardwareConfigSubkeys) foreach (string configId in hardwareConfigSubkeys)
{ {
logger.Info($"scanning configId: {configId}"); logger.Info($"scanning configId: {configId}");
var configKey = $"HKEY_LOCAL_MACHINE\\SYSTEM\\HardwareConfig\\{configId}"; var hwConfigKey = $"{hwConfigParentKey}\\{configId}";
// collect system values for IsVirtualSystemInfo()
object biosVendor; object biosVendor;
object biosVersion; object biosVersion;
object systemManufacturer; object systemManufacturer;
@ -126,10 +128,10 @@ namespace SafeExamBrowser.SystemComponents
bool success = true; bool success = true;
success &= registry.TryRead(configKey, "BIOSVendor", out biosVendor); success &= registry.TryRead(hwConfigKey, "BIOSVendor", out biosVendor);
success &= registry.TryRead(configKey, "BIOSVersion", out biosVersion); success &= registry.TryRead(hwConfigKey, "BIOSVersion", out biosVersion);
success &= registry.TryRead(configKey, "SystemManufacturer", out systemManufacturer); success &= registry.TryRead(hwConfigKey, "SystemManufacturer", out systemManufacturer);
success &= registry.TryRead(configKey, "SystemProductName", out systemProductName); success &= registry.TryRead(hwConfigKey, "SystemProductName", out systemProductName);
if (!success) if (!success)
continue; continue;
@ -139,18 +141,19 @@ namespace SafeExamBrowser.SystemComponents
isVirtualMachine |= IsVirtualSystemInfo(biosInfo, (string) systemManufacturer, (string) systemProductName); isVirtualMachine |= IsVirtualSystemInfo(biosInfo, (string) systemManufacturer, (string) systemProductName);
// hardware information of profile throughout installation etc. // check even more hardware information
IEnumerable<string> computerIds; IEnumerable<string> computerIdNames;
if (!registry.TryGetSubKeys($"HKLM\\SYSTEM\\HardwareConfig\\{configId}\\ComputerIds", out computerIds)) var computerIdsKey = $"{hwConfigKey}\\ComputerIds";
return false; if (!registry.TryGetNames(computerIdsKey, out computerIdNames))
continue;
foreach (var computerId in computerIds) foreach (var computerIdName in computerIdNames)
{ {
logger.Info($"computerId: {computerId}"); logger.Info($"computerId: {computerIdName}");
// e.g. manufacturer&version&sku&...
object computerSummary; // = (string) computerIds.GetValue(computerId); // collect computer hardware summary (e.g. manufacturer&version&sku&...)
object computerSummary;
if (!registry.TryRead($"HKLM\\SYSTEM\\HardwareConfig\\{configId}\\ComputerIds", computerId, out computerSummary)) if (!registry.TryRead(computerIdsKey, computerIdName, out computerSummary))
continue; continue;
isVirtualMachine |= IsVirtualSystemInfo((string) computerSummary, (string) systemManufacturer, (string) systemProductName); isVirtualMachine |= IsVirtualSystemInfo((string) computerSummary, (string) systemManufacturer, (string) systemProductName);