From 70ba9ad7b671d1345ba36f24f7aa6329cf6fc7a3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Damian=20B=C3=BCchel?= Date: Mon, 22 Jan 2024 10:38:05 +0100 Subject: [PATCH] SEBWIN-834: Fixed duplicate use of terminate method for proctoring implementations. --- .../JitsiMeet/JitsiMeetImplementation.cs | 10 +++++----- SafeExamBrowser.Proctoring/ProctoringImplementation.cs | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/SafeExamBrowser.Proctoring/JitsiMeet/JitsiMeetImplementation.cs b/SafeExamBrowser.Proctoring/JitsiMeet/JitsiMeetImplementation.cs index 7026baba..28bcdbf8 100644 --- a/SafeExamBrowser.Proctoring/JitsiMeet/JitsiMeetImplementation.cs +++ b/SafeExamBrowser.Proctoring/JitsiMeet/JitsiMeetImplementation.cs @@ -77,11 +77,6 @@ namespace SafeExamBrowser.Proctoring.JitsiMeet } } - public override void Terminate() - { - logger.Info("Terminated proctoring."); - } - internal override void Initialize() { var start = true; @@ -200,6 +195,11 @@ namespace SafeExamBrowser.Proctoring.JitsiMeet } } + internal override void Terminate() + { + logger.Info("Terminated proctoring."); + } + private string LoadContent(ProctoringSettings settings) { var assembly = Assembly.GetAssembly(typeof(ProctoringController)); diff --git a/SafeExamBrowser.Proctoring/ProctoringImplementation.cs b/SafeExamBrowser.Proctoring/ProctoringImplementation.cs index b77f0806..7d5f95f3 100644 --- a/SafeExamBrowser.Proctoring/ProctoringImplementation.cs +++ b/SafeExamBrowser.Proctoring/ProctoringImplementation.cs @@ -23,12 +23,13 @@ namespace SafeExamBrowser.Proctoring public abstract event NotificationChangedEventHandler NotificationChanged; public abstract void Activate(); - public abstract void Terminate(); + void INotification.Terminate() { } internal abstract void Initialize(); internal abstract void ProctoringConfigurationReceived(bool allowChat, bool receiveAudio, bool receiveVideo); internal abstract void ProctoringInstructionReceived(ProctoringInstructionEventArgs args); internal abstract void StartProctoring(); internal abstract void StopProctoring(); + internal abstract void Terminate(); } }