zervo/seb-win-refactoring
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SEBWIN-220: Letting ConfigurationOperationTests fail until mechanism is finished.

Browse source
This commit is contained in:
dbuechel 2018-06-21 09:14:14 +02:00
parent cd5bbfcb47
commit a74609eb46
2 changed files with 47 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
SafeExamBrowser.Contracts/Browser/DownloadFinishedCallback.cs
View file

@ -8,5 +8,9 @@
namespace SafeExamBrowser.Contracts.Browser namespace SafeExamBrowser.Contracts.Browser
{ {
/// <summary>
/// Defines the method signature for callbacks to be executed once a download has been finished. Indicates whether the download was
/// successful, and if so, where it was saved.
/// </summary>
public delegate void DownloadFinishedCallback(bool success, string filePath = null); public delegate void DownloadFinishedCallback(bool success, string filePath = null);
} }

83
SafeExamBrowser.Runtime.UnitTests/Behaviour/Operations/ConfigurationOperationTests.cs
View file

@ -6,16 +6,12 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. * file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/ */
using System;
using System.IO;
using Microsoft.VisualStudio.TestTools.UnitTesting; using Microsoft.VisualStudio.TestTools.UnitTesting;
using Moq; using Moq;
using SafeExamBrowser.Contracts.Behaviour.OperationModel;
using SafeExamBrowser.Contracts.Configuration; using SafeExamBrowser.Contracts.Configuration;
using SafeExamBrowser.Contracts.Configuration.Settings; using SafeExamBrowser.Contracts.Configuration.Settings;
using SafeExamBrowser.Contracts.I18n; using SafeExamBrowser.Contracts.I18n;
using SafeExamBrowser.Contracts.Logging; using SafeExamBrowser.Contracts.Logging;
using SafeExamBrowser.Contracts.UserInterface;
using SafeExamBrowser.Contracts.UserInterface.MessageBox; using SafeExamBrowser.Contracts.UserInterface.MessageBox;
using SafeExamBrowser.Runtime.Behaviour.Operations; using SafeExamBrowser.Runtime.Behaviour.Operations;
@ -53,41 +49,43 @@ namespace SafeExamBrowser.Runtime.UnitTests.Behaviour.Operations
[TestMethod] [TestMethod]
public void MustNotFailWithoutCommandLineArgs() public void MustNotFailWithoutCommandLineArgs()
{ {
repository.Setup(r => r.LoadDefaultSettings()); //repository.Setup(r => r.LoadDefaultSettings());
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
sut.Perform(); //sut.Perform();
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new string[] { }); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new string[] { });
sut.Perform(); //sut.Perform();
repository.Verify(r => r.LoadDefaultSettings(), Times.Exactly(2)); //repository.Verify(r => r.LoadDefaultSettings(), Times.Exactly(2));
Assert.Fail();
} }
[TestMethod] [TestMethod]
public void MustNotFailWithInvalidUri() public void MustNotFailWithInvalidUri()
{ {
var path = @"an/invalid\path.'*%yolo/()"; //var path = @"an/invalid\path.'*%yolo/()";
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new [] { "blubb.exe", path }); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new [] { "blubb.exe", path });
sut.Perform(); //sut.Perform();
Assert.Fail();
} }
[TestMethod] [TestMethod]
public void MustUseCommandLineArgumentAs1stPrio() public void MustUseCommandLineArgumentAs1stPrio()
{ {
var path = @"http://www.safeexambrowser.org/whatever.seb"; //var path = @"http://www.safeexambrowser.org/whatever.seb";
var location = Path.GetDirectoryName(GetType().Assembly.Location); //var location = Path.GetDirectoryName(GetType().Assembly.Location);
info.ProgramDataFolder = location; //info.ProgramDataFolder = location;
info.AppDataFolder = location; //info.AppDataFolder = location;
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new[] { "blubb.exe", path }); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, new[] { "blubb.exe", path });
sut.Perform(); //sut.Perform();
Assert.Fail(); Assert.Fail();
//repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(path)))), Times.Once); //repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(path)))), Times.Once);
@ -96,14 +94,14 @@ namespace SafeExamBrowser.Runtime.UnitTests.Behaviour.Operations
[TestMethod] [TestMethod]
public void MustUseProgramDataAs2ndPrio() public void MustUseProgramDataAs2ndPrio()
{ {
var location = Path.GetDirectoryName(GetType().Assembly.Location); //var location = Path.GetDirectoryName(GetType().Assembly.Location);
info.ProgramDataFolder = location; //info.ProgramDataFolder = location;
info.AppDataFolder = $@"{location}\WRONG"; //info.AppDataFolder = $@"{location}\WRONG";
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
sut.Perform(); //sut.Perform();
Assert.Fail(); Assert.Fail();
//repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(Path.Combine(location, "SettingsDummy.txt"))))), Times.Once); //repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(Path.Combine(location, "SettingsDummy.txt"))))), Times.Once);
@ -112,13 +110,13 @@ namespace SafeExamBrowser.Runtime.UnitTests.Behaviour.Operations
[TestMethod] [TestMethod]
public void MustUseAppDataAs3rdPrio() public void MustUseAppDataAs3rdPrio()
{ {
var location = Path.GetDirectoryName(GetType().Assembly.Location); //var location = Path.GetDirectoryName(GetType().Assembly.Location);
info.AppDataFolder = location; //info.AppDataFolder = location;
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
sut.Perform(); //sut.Perform();
Assert.Fail(); Assert.Fail();
//repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(Path.Combine(location, "SettingsDummy.txt"))))), Times.Once); //repository.Verify(r => r.LoadSettings(It.Is<Uri>(u => u.Equals(new Uri(Path.Combine(location, "SettingsDummy.txt"))))), Times.Once);
@ -127,36 +125,41 @@ namespace SafeExamBrowser.Runtime.UnitTests.Behaviour.Operations
[TestMethod] [TestMethod]
public void MustFallbackToDefaultsAsLastPrio() public void MustFallbackToDefaultsAsLastPrio()
{ {
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
sut.Perform(); //sut.Perform();
repository.Verify(r => r.LoadDefaultSettings(), Times.Once); //repository.Verify(r => r.LoadDefaultSettings(), Times.Once);
Assert.Fail();
} }
[TestMethod] [TestMethod]
public void MustAbortIfWishedByUser() public void MustAbortIfWishedByUser()
{ {
info.ProgramDataFolder = Path.GetDirectoryName(GetType().Assembly.Location); //info.ProgramDataFolder = Path.GetDirectoryName(GetType().Assembly.Location);
messageBox.Setup(u => u.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxAction>(), It.IsAny<MessageBoxIcon>())).Returns(MessageBoxResult.Yes); //messageBox.Setup(u => u.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxAction>(), It.IsAny<MessageBoxIcon>())).Returns(MessageBoxResult.Yes);
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
var result = sut.Perform(); //var result = sut.Perform();
Assert.AreEqual(OperationResult.Aborted, result); //Assert.AreEqual(OperationResult.Aborted, result);
Assert.Fail();
} }
[TestMethod] [TestMethod]
public void MustNotAbortIfNotWishedByUser() public void MustNotAbortIfNotWishedByUser()
{ {
messageBox.Setup(u => u.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxAction>(), It.IsAny<MessageBoxIcon>())).Returns(MessageBoxResult.No); //messageBox.Setup(u => u.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxAction>(), It.IsAny<MessageBoxIcon>())).Returns(MessageBoxResult.No);
sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null); //sut = new ConfigurationOperation(repository.Object, logger.Object, messageBox.Object, info, text.Object, null);
var result = sut.Perform(); //var result = sut.Perform();
Assert.AreEqual(OperationResult.Success, result); //Assert.AreEqual(OperationResult.Success, result);
Assert.Fail();
} }
} }
} }