zervo/seb-win-refactoring
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SEBWIN-703, #604: Fixed false-positive VM detection due to virtual disk devices.

Browse source
This commit is contained in:
Damian Büchel 2023-05-02 14:56:15 +02:00
parent 557e8a6be4
commit e33a12e7ec
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
SafeExamBrowser.SystemComponents/VirtualMachineDetector.cs
View file

@ -14,7 +14,10 @@ namespace SafeExamBrowser.SystemComponents
{ {
public class VirtualMachineDetector : IVirtualMachineDetector public class VirtualMachineDetector : IVirtualMachineDetector
{ {
private static readonly string[] DEVICE_BLACKLIST = private const string QEMU_MAC_PREFIX = "525400";
private const string VIRTUALBOX_MAC_PREFIX = "080027";
private static readonly string[] DeviceBlacklist =
{ {
// Hyper-V // Hyper-V
"PROD_VIRTUAL", "HYPER_V", "PROD_VIRTUAL", "HYPER_V",
@ -25,8 +28,12 @@ namespace SafeExamBrowser.SystemComponents
// VMware // VMware
"PROD_VMWARE", "VEN_VMWARE", "VMWARE_IDE" "PROD_VMWARE", "VEN_VMWARE", "VMWARE_IDE"
}; };
private static readonly string QEMU_MAC_PREFIX = "525400";
private static readonly string VIRTUALBOX_MAC_PREFIX = "080027"; private static readonly string[] DeviceWhitelist =
{
// Microsoft Virtual Disk
"PROD_VIRTUAL_DISK"
};
private readonly ILogger logger; private readonly ILogger logger;
private readonly ISystemInfo systemInfo; private readonly ISystemInfo systemInfo;
@ -62,7 +69,7 @@ namespace SafeExamBrowser.SystemComponents
foreach (var device in devices) foreach (var device in devices)
{ {
isVirtualMachine |= DEVICE_BLACKLIST.Any(d => device.ToLower().Contains(d.ToLower())); isVirtualMachine |= DeviceBlacklist.Any(d => device.ToLower().Contains(d.ToLower())) && DeviceWhitelist.All(d => !device.ToLower().Contains(d.ToLower()));
} }
logger.Debug($"Computer '{systemInfo.Name}' appears {(isVirtualMachine ? "" : "not ")}to be a virtual machine."); logger.Debug($"Computer '{systemInfo.Name}' appears {(isVirtualMachine ? "" : "not ")}to be a virtual machine.");