From f0ec9a482169ce588fb281cdd6433443d743b48e Mon Sep 17 00:00:00 2001 From: dbuechel Date: Tue, 13 Mar 2018 10:04:42 +0100 Subject: [PATCH] SEBWIN-219: Important TODO regarding session restart in case of client failure. --- SafeExamBrowser.Runtime/Communication/RuntimeHost.cs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/SafeExamBrowser.Runtime/Communication/RuntimeHost.cs b/SafeExamBrowser.Runtime/Communication/RuntimeHost.cs index 4fe1249a..5625d8dc 100644 --- a/SafeExamBrowser.Runtime/Communication/RuntimeHost.cs +++ b/SafeExamBrowser.Runtime/Communication/RuntimeHost.cs @@ -51,6 +51,12 @@ namespace SafeExamBrowser.Runtime.Communication protected override void OnDisconnect() { ClientDisconnected?.Invoke(); + // TODO: Handle client crash scenario! + // If a client crashes or hangs when terminating (which should not happen!), it could be that it never gets to disconnect from + // the RuntimeHost - in that case, allowConnection prohibits restarting a new session as long as it's only set here! + // -> Move AllowConnection to interface and reset it in SessionController? + // -> Only possible as long as just the client connects, with service and client a more elaborate solution will be needed! + // -> E.g. ClientId and ServiceId, and then AllowClientConnection and AllowServiceConnection? allowConnection = true; }