zervo/seb-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SEBSERV-580 fixed by skip active testing for Exam without LMS

Browse source
This commit is contained in:
anhefti 2024-08-21 10:52:09 +02:00
parent bb0df16a56
commit 9e5a0085b3
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/ScreenProctoringService.java
View file

@ -100,7 +100,7 @@ public interface ScreenProctoringService extends SessionUpdateTask {
void updateClientConnections(); void updateClientConnections();
/** This goes through all running exams with screen proctoring enabled and updates the group attributes /** This goes through all running exams with screen proctoring enabled and updates the group attributes
* (mainly the number of active clients in the group) by call ing SPS API and store newest data. */ * (mainly the number of active clients in the group) by calling SPS API and store newest data. */
void updateActiveGroups(); void updateActiveGroups();
@Async(AsyncServiceSpringConfig.EXECUTOR_BEAN_NAME) @Async(AsyncServiceSpringConfig.EXECUTOR_BEAN_NAME)

3
src/main/java/ch/ethz/seb/sebserver/webservice/servicelayer/session/impl/proctoring/ScreenProctoringServiceImpl.java
View file

@ -577,6 +577,7 @@ public class ScreenProctoringServiceImpl implements ScreenProctoringService {
log.debug("Register JOIN instruction for client "); log.debug("Register JOIN instruction for client ");
} }
final boolean checkActive = exam.lmsSetupId != null;
final SPSData spsData = this.screenProctoringAPIBinding.getSPSData(exam.id); final SPSData spsData = this.screenProctoringAPIBinding.getSPSData(exam.id);
final String url = screenProctoringServiceBundle.bundled final String url = screenProctoringServiceBundle.bundled
? screenProctoringServiceBundle.serviceURL ? screenProctoringServiceBundle.serviceURL
@ -597,7 +598,7 @@ public class ScreenProctoringServiceImpl implements ScreenProctoringService {
InstructionType.SEB_PROCTORING, InstructionType.SEB_PROCTORING,
attributes, attributes,
ccRecord.getConnectionToken(), ccRecord.getConnectionToken(),
true, checkActive,
true) true)
.onError(error -> log.error( .onError(error -> log.error(
"Failed to register screen proctoring join instruction for SEB connection: {}", "Failed to register screen proctoring join instruction for SEB connection: {}",