zervo/seb-win-refactoring
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SEBWIN-219: Important TODO regarding session restart in case of client failure.

Browse source
This commit is contained in:
dbuechel 2018-03-13 10:04:42 +01:00
parent 4e2e43ede3
commit f0ec9a4821
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
SafeExamBrowser.Runtime/Communication/RuntimeHost.cs
View file

@ -51,6 +51,12 @@ namespace SafeExamBrowser.Runtime.Communication
protected override void OnDisconnect() protected override void OnDisconnect()
{ {
ClientDisconnected?.Invoke(); ClientDisconnected?.Invoke();
// TODO: Handle client crash scenario!
// If a client crashes or hangs when terminating (which should not happen!), it could be that it never gets to disconnect from
// the RuntimeHost - in that case, allowConnection prohibits restarting a new session as long as it's only set here!
// -> Move AllowConnection to interface and reset it in SessionController?
// -> Only possible as long as just the client connects, with service and client a more elaborate solution will be needed!
// -> E.g. ClientId and ServiceId, and then AllowClientConnection and AllowServiceConnection?
allowConnection = true; allowConnection = true;
} }